[Autocomplete] Avoid handling InvalidArgumentException

evertharmeling · evertharmeling · commit 81b4807db343 · 2024-02-15T15:30:35.000+01:00
diff --git a/src/Autocomplete/src/Doctrine/EntityMetadata.php b/src/Autocomplete/src/Doctrine/EntityMetadata.php
@@ -84,11 +84,11 @@ public function getAssociationMetadata(string $propertyName): array
 
     public function getPropertyDataType(string $propertyName): string
     {
-        try {
+        if (\array_key_exists($propertyName, $this->metadata->fieldMappings)) {
             return $this->getFieldMetadata($propertyName)['type'];
-        } catch (\InvalidArgumentException $e) {
-            return $this->getAssociationMetadata($propertyName)['type'];
         }
+
+        return $this->getAssociationMetadata($propertyName)['type'];
     }
 
     public function getIdValue(object $entity): string

Original file line number	Diff line number	Diff line change
`@@ -84,11 +84,11 @@ public function getAssociationMetadata(string $propertyName): array`
`84`	`84`
`85`	`85`	`public function getPropertyDataType(string $propertyName): string`
`86`	`86`	`{`
`87`		`- try {`
	`87`	`+ if (\array_key_exists($propertyName, $this->metadata->fieldMappings)) {`
`88`	`88`	`return $this->getFieldMetadata($propertyName)['type'];`
`89`		`- } catch (\InvalidArgumentException $e) {`
`90`		`- return $this->getAssociationMetadata($propertyName)['type'];`
`91`	`89`	`}`
	`90`	`+`
	`91`	`+ return $this->getAssociationMetadata($propertyName)['type'];`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`public function getIdValue(object $entity): string`