[Autocomplete] Simplified get*MetaData methods

Author: evertharmeling

src/Autocomplete/src/Doctrine/EntityMetadata.php

@@ -60,14 +60,8 @@ public function getPropertyMetadata(string $propertyName): array
     public function getFieldMetadata(string $propertyName): array
     {
         if (\array_key_exists($propertyName, $this->metadata->fieldMappings)) {
-            $metadata = $this->metadata->fieldMappings[$propertyName];
-
-            // In doctrine/orm:^3.0; $metadata will be a FieldMapping object
-            if (!\is_array($metadata)) {
-                return (array) $metadata;
-            }
-
-            return $metadata;
+            // Cast to array, because in doctrine/orm:^3.0; $metadata will be a FieldMapping object
+            return (array) $this->metadata->fieldMappings[$propertyName];
         }
 
         throw new \InvalidArgumentException(sprintf('The "%s" field does not exist in the "%s" entity.', $propertyName, $this->metadata->getName()));
@@ -81,14 +75,8 @@ public function getFieldMetadata(string $propertyName): array
     public function getAssociationMetadata(string $propertyName): array
     {
         if (\array_key_exists($propertyName, $this->metadata->associationMappings)) {
-            $metadata = $this->metadata->associationMappings[$propertyName];
-
-            // In doctrine/orm:^3.0; $metadata will be an AssociationMapping object
-            if (!\is_array($metadata)) {
-                return (array) $metadata;
-            }
-
-            return $metadata;
+            // Cast to array, because in doctrine/orm:^3.0; $metadata will be an AssociationMapping object
+            return (array) $this->metadata->associationMappings[$propertyName];
         }
 
         throw new \InvalidArgumentException(sprintf('The "%s" field does not exist in the "%s" entity.', $propertyName, $this->metadata->getName()));