[FrameworkBundle] Fix allow loose as an email validation mode

[rhel-eo]

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

After upgrading to Symfony 7.2.7 we observe this error:

In EnumNode.php line 82:
                                                                               
  The value "loose" is not allowed for path "framework.validation.email_valid  
  ation_mode". Permissible values: "html5-allow-no-tld", "html5", "strict"     
                                                                               

Our configuration is:

framework:
    ...
    validation:
        ...
        email_validation_mode: loose

From bin/console config:dump-reference framework we observe:

framework:
...
    validation:
        ...
        email_validation_mode: html5 # One of "html5-allow-no-tld"; "html5"; "strict"

After this change, the above error no longer occurs and expected allowed values are observed:

$ php bin/console config:dump-reference framework
framework:
...
    validation:
        ...
        email_validation_mode: ~ # One of "html5-allow-no-tld"; "html5"; "strict"; "loose"

See #60373 and #60365 where the previous code was introduced.

[stof]

Can you also add loose in the emailValidationModeProvider of the test added in #60365 to have a non-regression test ?

[stof]

Actually, I think the array_merge should be dropped (putting loose in the fallback array when the class does not exist anymore):

• Email::VALIDATION_MODES contains loose in 6.4
• in 7.x where loose does not exist in Email::VALIDATION_MODES, using loose is not supported and should indeed be reported as invalid config (instead of failing when instantiating the service)

[stof]

Suggested change

	->enumNode('email_validation_mode')->values(array_merge(class_exists(Email::class) ? Email::VALIDATION_MODES : ['html5-allow-no-tld', 'html5', 'strict'], ['loose']))->end()
	->enumNode('email_validation_mode')->values(class_exists(Email::class) ? Email::VALIDATION_MODES : ['html5-allow-no-tld', 'html5', 'strict', 'loose'])->end()

[nicolas-grekas]

actually I think we should keep it this way to make it easier to handle the const when Symfony 8 is installed (since there we plan to remove the loose mode from the list)

[rhel-eo]

Prior to the change in #60365, the validation of this config option explicitly included loose, so I understood the intention was to avoid a patch release breaking projects that were using this value in their config.

With the suggested change, projects that were using the previously allowed loose value would still receive a configuration validation error after a patch update.

If you prefer to make this explicitly invalid because it is not supported, I understand that decision but wouldn't be able to contribute that on this PR as I don't have the context around any other consequences.

[stof]

ah, I missed that we forgot to change the FrameworkBundle config in 7.0, and that some projects not using the constraint might have an invalid config.

So yes, keep loose in the list all the time. And then, submit another PR to the 7.4 branch to deprecate the loose value

[rhel-eo]

Thanks, I've opened #60706 for that follow up change.

[nicolas-grekas]

Looks like some comments from @stof are still to be accounted for, isn't it?

[nicolas-grekas]

Thank you @rhel-eo.