Skip to content

[Security] Update InteractiveAuthenticatorInterface description #52082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT

SecurityEvents phpdoc and InteractiveAuthenticatorInterface are contradictory, this PR try to fix it

* The INTERACTIVE_LOGIN event occurs after a user has actively logged
* into your website. It is important to distinguish this action from
* non-interactive authentication methods, such as:
* - authentication based on your session.
* - authentication using an HTTP basic or HTTP digest header.
*
* @Event("Symfony\Component\Security\Http\Event\InteractiveLoginEvent")
*/

Found it when documenting InteractiveLoginEvent symfony/symfony-docs#19029

@alamirault alamirault requested a review from chalasr as a code owner October 16, 2023 19:25
@carsonbot carsonbot added this to the 5.4 milestone Oct 16, 2023
@alamirault alamirault changed the title [Security] Update InteractiveAuthenticatorInterface description [Security] Update InteractiveAuthenticatorInterface description Oct 16, 2023
@OskarStark OskarStark requested review from wouterj and stof October 17, 2023 05:01
@alamirault alamirault force-pushed the hotfix/fix-wrong-phpdoc branch from 0c6f3e5 to 0a66c2b Compare January 6, 2024 11:59
@fabpot
Copy link
Member

fabpot commented Feb 2, 2024

Thank you @alamirault.

@fabpot fabpot merged commit f7f83bc into symfony:5.4 Feb 2, 2024
@alamirault alamirault deleted the hotfix/fix-wrong-phpdoc branch February 4, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants