[Scheduler] Trigger unique messages at runtime #51542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeroeny
force-pushed
the
schedule
branch
2 times, most recently
from
fa83bdb to
777c5a4
Compare
fabpot
requested changes
Sep 15, 2023
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Sep 15, 2023
src/Symfony/Component/Scheduler/Tests/Generator/MessageGeneratorTest.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Sep 15, 2023
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php
Outdated
Show resolved
Hide resolved
fabpot
reviewed
Sep 15, 2023
Jeroeny
force-pushed
the
schedule
branch
2 times, most recently
from
a969434 to
8869bd7
Compare
stof
reviewed
Sep 15, 2023
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php
Outdated
Show resolved
Hide resolved
fabpot
requested changes
Sep 26, 2023
src/Symfony/Component/Scheduler/Trigger/FixedMessageProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Trigger/FixedMessageProvider.php
Outdated
Show resolved
Hide resolved
Jeroeny
force-pushed
the
schedule
branch
2 times, most recently
from
d9a196e to
e98bbe3
Compare
fabpot
reviewed
Sep 27, 2023
src/Symfony/Component/Scheduler/Trigger/StaticMessageProvider.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Sep 27, 2023
|
Thank you @Jeroeny. |
|
Thanks! |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages in a schedule (
RecurringMessage) are created at compile time, per Trigger. This means a trigger will always give the same message. This limits the usefulness of the component, because messages can often be dynamic. E.g. with a specific payload from the database or with a Uuid per message (often the case with architectures like EventSourcing / cqrs).Also there is no way for a trigger to only 'check' what the getNextRunDate is, without always triggering a message.
This PR makes it possible to yield zero or more messages when a trigger is triggered. Due to the trigger being a method, the messages can be created at runtime, with a unique payload (or directly serving messages from a DB table).
Since the component is still experimental in 6.3, it's probably good to get something like this in before 6.4 is released.