[HttpClient] yield a last chunk for completed responses also #30513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
hc-last-chunk
branch
from
9b339ca
to
e11ef7e
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Mar 12, 2019
…so (nicolas-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpClient] yield a last chunk for completed responses also | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When a response completed, streaming it again yields no chunks right now. This PR makes it yield a `LastChunk` - or an `ErrorChunk` when applicable. The reasoning for the previous behavior was that streams should yield only activity from the network. But this looks more complex to use in practice. The proposed behavior is simpler to reason about I think. Commits ------- e11ef7e [HttpClient] yield a last chunk for completed responses also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a response completed, streaming it again yields no chunks right now.
This PR makes it yield a
LastChunk- or anErrorChunkwhen applicable.The reasoning for the previous behavior was that streams should yield only activity from the network.
But this looks more complex to use in practice. The proposed behavior is simpler to reason about I think.