[Framework] allow to create kernel-aware console applications without default commands

[FrancescoBorzi]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT
Doc PR	symfony/symfony-docs#7296

Suppose that you need to create a kernel-aware application:

// ...
$kernel = new AppKernel($env, $debug);
$application = new MyApplication($kernel);

$application->addCommands([
    // CUstom commands
    new MyCustomCommand(),
]);

$application->run($input);

The code above will create a console application with MyCustomCommand plus all the other default symfony commands.

With this PR you are able to specify whether or not you want to add the default commands:

$application = new MyApplication($kernel, false);
or
$application = new MyApplication($kernel, true); (default)

[FrancescoBorzi]

@ro0NL here

[ro0NL]

You could have changed the base branch on your previous PR as well ;-)

You should add a test if this is accepted 👍

[linaori]

This should make it easier to create single command applications I believe?

[FrancescoBorzi]

@iltar yes, in particular kernel-aware ones

[FrancescoBorzi]

Thanks all for reviewing this.

Now about the doc part, is there already a page which explains how to create kernel-aware console applications?

Afaik the only place where Symfony\Bundle\FrameworkBundle\Console\Application is mentioned is for testing commands.

[ro0NL]

Maybe a special note at https://symfony.com/doc/current/components/console/single_command_tool.html?

Howto create a single command app with the framework something like that?

[FrancescoBorzi]

@ro0NL I don't think so, because it hasn't to be necessarily one single command. It can be even with multiple commands.

Maybe it's better to create a new dedicated page about "How to create a kernel-aware console application" ?

[ro0NL]

It's about creating awareness of this small feature. I think the single command tool page has the most visits by now, and is best indexed.

Besides, this definitely relates to creating a truly single command tool with the framework ;-) If we explain it right there, people will probably understand this is applies to multiple commands as well.

[FrancescoBorzi]

PR for the doc done:

symfony/symfony-docs#7296

[FrancescoBorzi]

any news?

[lyrixx]

I would name it registerDefaultCommands to be consistent.

[nicolas-grekas]

Moving to 4.1. Rebase on master needed, where PHP 7.1 features can be used btw.

[OskarStark]

@FrancescoBorzi can you please rebase this PR?

[FrancescoBorzi]

I opened this PR on 22 Dec 2016 so almost 3 years ago.

I no longer use Symfony for a while and to be honest I don't even remember what I did here.

Sorry.