Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

[README] Add DebugBundle to the list #824

Closed
wants to merge 3 commits into from
Closed

[README] Add DebugBundle to the list #824

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2015

Q A
Bug fix? [no]
New feature? [no]
BC breaks? [no]
Deprecations? [no]
Tests pass? [yes]
Fixed tickets
License MIT
Doc PR

This commits mentions DebugBundle in the readme. I believe this should also be ported to 2.7, 2.8 and master branches.

Have a nice weekend!

@@ -53,6 +53,9 @@ It comes pre-configured with the following bundles:
* [**SensioGeneratorBundle**][13] (in dev/test env) - Adds code generation
capabilities

* **DebugBundle** (in dev/test env) - Adds debug and VardDumper component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VarDumper instead of VardDumper 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Fixed in last commit

@@ -53,6 +53,9 @@ It comes pre-configured with the following bundles:
* [**SensioGeneratorBundle**][13] (in dev/test env) - Adds code generation
capabilities

* **DebugBundle** (in dev/test env) - Adds debug and VarDumper component
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of the Debug component should have a capital letter too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in the latest commit.

@ghost
Copy link
Author

ghost commented Jun 15, 2015

I have updated it according to comments. If there is anything else - please let me know.

@fabpot
Copy link
Member

fabpot commented Jun 15, 2015

Thank you @edvinasme.

fabpot added a commit that referenced this pull request Jun 15, 2015
This PR was squashed before being merged into the 2.6 branch (closes #824).

Discussion
----------

[README] Add DebugBundle to the list

| Q             | A
| ------------- | ---
| Bug fix?      | [no]
| New feature?  | [no]
| BC breaks?    | [no]
| Deprecations? | [no]
| Tests pass?   | [yes]
| Fixed tickets |
| License       | MIT
| Doc PR        |

This commits mentions **DebugBundle** in the readme. I believe this should also be ported to 2.7, 2.8 and master branches.

Have a nice weekend!

Commits
-------

b557e01 [README] Add DebugBundle to the list
@fabpot fabpot closed this Jun 15, 2015
@ghost ghost deleted the readme-add-debug-bundle branch June 15, 2015 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants