Use 'server:start' instead of 'server:run' when possible #284
Conversation
|
Should be deal with Symfony Version also ? because this command does not exist in older SF version. |
|
@lyrixx you are right! I've improved the condition to check that we're using Sf 2.6.0 or higher. Thanks! |
| @@ -145,11 +145,13 @@ private function displayInstallationResult() | |||
| )); | |||
| } | |||
|
|
|||
| $serverRunCommand = version_compare($this->version, '2.6.0', '>=') && extension_loaded('pcntl') ? 'server:start' : 'server:run'; | |||
There was a problem hiding this comment.
Do we need this for the demo application?
There was a problem hiding this comment.
I don't know why should it be different for the demo app 😕
There was a problem hiding this comment.
You cannot select a version of the demo application, can you? And the one that is going to be installed is using Symfony 3 already, isn't it?
There was a problem hiding this comment.
You are so right!! I'm sorry for this mistake. It's now fixed. Thanks!
| @@ -256,14 +256,15 @@ protected function displayInstallationResult() | |||
| } | |||
|
|
|||
| $consoleDir = ($this->isSymfony3() ? 'bin' : 'app'); | |||
| $serverRunCommand = version_compare($this->version, '2.6.0', '>=') && extension_loaded('pcntl') ? 'server:start' : 'server:run'; | |||
There was a problem hiding this comment.
You also need to check for HHVM.
There was a problem hiding this comment.
I don't think that we should care about HHVM anymore. "Nobody" is using it.
server:startis a better option ... but it's not always possible to run it.