This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Added support for using proxy servers #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return Client | ||
| */ | ||
| protected function getGuzzleClient() |
There was a problem hiding this comment.
Is there a reason not to make this private?
There was a problem hiding this comment.
You can't call private methods in subclasses :)
There was a problem hiding this comment.
It wasn't used in another class the time I wrote the comment. :D
There was a problem hiding this comment.
You both are right! Thanks for reviewing the code.
|
The |
|
Nice catch! Fixed. Thanks. |
|
I'm going to merge this now and release a new installer version. The code looks "safe enough" to not break anything if you are not using a proxy. And it also looks like we're going to solve the problem at least for some proxy users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested it successfully with some free public proxy servers, but we should definitely test it with "real" proxy servers.