This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Add previous exception for some 'unknown errors' #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows debugging easier, especially when Distill does throw an exception.
|
@Pierstoval 👍 I like it. To me it's a safe and useful merge, but I'll wait to see if there are more code reviews. Thanks. |
|
👍 |
1 similar comment
|
👍 |
|
Thanks @Pierstoval. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 1, 2015
…oval) This PR was merged into the 1.0-dev branch. Discussion ---------- Add previous exception for some 'unknown errors' At the moment, we don't have that many clues when people can't install Symfony and when we can't guess what is the problem with the backtrace. This PR allows debugging easier, especially when Distill does throw an exception. This is related to #129 Commits ------- a2f6c6d Add previous exception for some 'unknown errors'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we don't have that many clues when people can't install Symfony and when we can't guess what is the problem with the backtrace.
This PR allows debugging easier, especially when Distill does throw an exception.
This is related to #129