Skip to content
This repository was archived by the owner on Nov 14, 2019. It is now read-only.

set PATH environment variable for Windows #125

Merged
merged 1 commit into from
Mar 29, 2015
Merged

set PATH environment variable for Windows #125

merged 1 commit into from
Mar 29, 2015

Conversation

sstok
Copy link
Contributor

@sstok sstok commented Mar 29, 2015

Windows uses Path instead of PATH which causes a notice for the about and download command.

@javiereguiluz
Copy link
Member

@sstok thanks for this improvement. It looks totally safe to merge it, but since I'm not a Windows user, I prefer to wait until any Symfony developer with Windows experience (e.g. @stof or @wouterj) confirms it. Thanks for your patience.

@Pierstoval
Copy link
Contributor

I personally use Windows 7 as my dev environments, and it has never caused me any problem... 😕

@wouterj
Copy link
Member

wouterj commented Mar 29, 2015

@javiereguiluz I can confirm that this PR is correct (@sstok and me actually created this PR when helping a windows user with this error on IRC)

@Pierstoval the path env is only used by the command in the help message (if you run symfony) or if there was an error during the download. That might explain why you didn't see this message.

@javiereguiluz
Copy link
Member

@wouterj thanks for reviewing this change and thanks again to @sstok for improving the installer

@javiereguiluz javiereguiluz merged commit 7149b67 into symfony:master Mar 29, 2015
javiereguiluz added a commit that referenced this pull request Mar 29, 2015
This PR was merged into the 1.0-dev branch.

Discussion
----------

set PATH environment variable for Windows

Windows uses Path instead of PATH which causes a notice for the about and download command.

Commits
-------

7149b67 set PATH environment variable for Windows
@sstok sstok deleted the windows-path-fix branch March 29, 2015 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants