Fix the explanation about registering commands #9419
Conversation
console.rst
Outdated
| :class:`Symfony\\Component\\Console\\Command\\Command`, Symfony does this for | ||
| you automatically. | ||
| Symfony commands must be registered before using them. In order to be registered, | ||
| a command must bw: |
|
I don't know if we really need an explanation here. On http://symfony.com/doc/2.7/console/commands_as_services.html we already have an IMO good enough one. |
|
But this is the main article about Console, the only one who anybody interested in Symfony + commands is going to write. If you are new to Symfony I think you'll never look for "symfony commands as services" because you don't even know what a service is. |
|
Fair enough, but then we can probably better just borrow the sentences from the existing section, right? |
|
I looked into the original article but I didn't like it because it doesn't explain the conditions in a simple and comprehensive list. However, I made some changes here after your comments and I've added a link to that "commands as services" article. Thanks! |
|
Hmm, why did we remove the notion about the Otherwise, 👍 |
|
@wouter I made a lot of changes about this and merged some. so in 4.0 we mention that tag: https://github.com/symfony/symfony-docs/blob/master/console.rst#registering-the-command We just need to fix the 2.7 and 2.8 and 3.4 branches to fix the mistake I made in their explanation. |
A question to @xabbuh: we should merge this in 2.7, 2.8 and 3.4, right?