Skip to content

Fixing a typo on the mustRun method #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

benjamin-hubert
Copy link
Contributor

@benjamin-hubert benjamin-hubert commented Mar 9, 2018

On the mustRun method of the Process chapter, a bad argument is used on try {} catch{} section.

@javiereguiluz
Copy link
Member

@GOUAILLE nice catch! This is a leftover of our recent variable renaming. Thanks for fixing it ... and congrats on your first Symfony Docs contribution.

@javiereguiluz javiereguiluz merged commit b327ba8 into symfony:4.0 Mar 9, 2018
javiereguiluz added a commit that referenced this pull request Mar 9, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Fixing a typo on the mustRun method

On the mustRun method of the Process chapter, a bad argument is used on try {} catch{} section.

Commits
-------

b327ba8 Fixing a typo on the mustRun method
@benjamin-hubert benjamin-hubert deleted the patch-1 branch March 9, 2018 13:32
@xabbuh xabbuh added this to the 2.7 milestone Mar 9, 2018
xabbuh pushed a commit that referenced this pull request Mar 9, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Fixing a typo on the mustRun method

On the mustRun method of the Process chapter, a bad argument is used on try {} catch{} section.

Commits
-------

b327ba8 Fixing a typo on the mustRun method
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 10, 2018
* 2.7:
  Improved the "Installation" section of components
  minor symfony#9415 Fixing a typo on the mustRun method (gouaille)
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 10, 2018
* 2.8:
  Updated the installation instructions for components introduced in 2.8
  Improved the "Installation" section of components
  minor symfony#9415 Fixing a typo on the mustRun method (gouaille)
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 10, 2018
* 3.4:
  Updated the installation of components introduced in Symfony 3.4
  Updated the installation instructions for components introduced in 2.8
  Improved the "Installation" section of components
  minor symfony#9415 Fixing a typo on the mustRun method (gouaille)
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 10, 2018
* 4.0:
  Updated the installation of components introduced in Symfony 3.4
  Updated the installation instructions for components introduced in 2.8
  Improved the "Installation" section of components
  minor symfony#9415 Fixing a typo on the mustRun method (gouaille)
  Fixing a typo on the mustRun method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants