-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Documented the Twig extension priority #9135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How will this work if the service is also auto configured? |
@Xymanek same as the other tags that allow priority. When using autoconfiguration you get a priority of |
Maybe it makes sense to mention that in docs? Because someone can think that to change priority they need to add a new tag, ending up with the service being tagged twice. |
Not sure I follow you. You say Because someone can think that to change priority they need to add a new tag ... but that's exactly what you need to do. If you want a priority, you need to add the tag explicitly yourself. |
If you add a tag to auto configured service, won't that service end up with 2
|
This fixes #9096.