Skip to content

[Config] Allow changing the path separator #9100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

javiereguiluz
Copy link
Member

This fixes #9090.

@crevillo
Copy link

Another question here. is possible to set a separator having more than one char? Also, are there anything that we shouldn't use as separator to avoid problems?

@bburnichon
Copy link

There are currently no limitation about separator being a single char. It could be any length. There are also no restriction about separator you can use. Currently, it is meant for display keys in a nice consistent manner. In my use case, I wished to use a / as separator as some configuration keys had . in names already.

@javiereguiluz
Copy link
Member Author

Cool. Since there are no special constraints (length, allowed chars, etc.) there's no need to mention it. We usually only document constraints or things you can't do. Thanks!

@javiereguiluz javiereguiluz merged commit 7fb2322 into symfony:master Jan 25, 2018
javiereguiluz added a commit that referenced this pull request Jan 25, 2018
This PR was merged into the master branch.

Discussion
----------

[Config] Allow changing the path separator

This fixes #9090.

Commits
-------

7fb2322 [Config] Allow changing the path separator
@crevillo
Copy link

👍

@xabbuh xabbuh added this to the 4.1 milestone Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Config] allow changing the path separator
6 participants