-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Overhaul Deployment + a few other tweaks #8721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We cannot maintain these and keep them up to date
|
I think this change makes sense. Maybe drop the " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you said, the env var part is vague ... but I think it's good enough. When we have more experience with this new workflow, we'll make more specific recommendations.
deployment.rst
Outdated
|
||
deployment/* | ||
deployment/heroku |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of linking to those dead pages here, could we instead link to the real tutorials on those third-party websites? If you do that, you need to add :orphan:
at the beginning of the RST files to avoid the "this file is not linked in any TOC" error (like here: https://github.com/symfony/symfony-docs/blob/master/bundles/index.rst)
Great feedback - thanks guys :) |
Agree, duplicated content makes not much sense. |
deployment.rst
Outdated
.. _`Heroku`: https://devcenter.heroku.com/articles/getting-started-with-symfony | ||
.. _`platform.sh`: https://docs.platform.sh/frameworks/symfony.html | ||
.. _`Azure`: https://azure.microsoft.com/en-us/develop/php/ | ||
.. _`fortrabbit`: https://help.fortrabbit.com/install-symfony-3-uni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use https://help.fortrabbit.com/install-symfony
This way we are not tied to the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely - much nicer link :)
This PR was squashed before being merged into the 4.0 branch (closes #8721). Discussion ---------- Overhaul Deployment + a few other tweaks This removes all of the PAAS articles. I *really* like mentioning great PaaS, but it doesn't make sense for us to maintain the articles (and in practice, we don't maintain them). So, I've removed all of the articles. Ping @dzuelke, @Crell & @ostark. I just want you guys to be aware of this :). This updates `deployment.rst` to mention environment variables. But my description is SUPER weak (https://github.com/symfony/symfony-docs/pull/8721/files#diff-7691c197e7985b35df39ae74d6d58b8dR128)! My impression is that (outside a PaaS), setting environment variables is a pain, and varies widely. I want to give a better recommendation that I am right now. Commits ------- 3e463f6 updating link to be version independent 5b6ef2a linking directly and marking articles as orphans 9a1695d linking to missing article bbffb1a Removing all PAAS deployment articles b563ab2 using different example
This removes all of the PAAS articles. I really like mentioning great PaaS, but it doesn't make sense for us to maintain the articles (and in practice, we don't maintain them).
So, I've removed all of the articles. Ping @dzuelke, @Crell & @ostark. I just want you guys to be aware of this :).
This updates
deployment.rst
to mention environment variables. But my description is SUPER weak (https://github.com/symfony/symfony-docs/pull/8721/files#diff-7691c197e7985b35df39ae74d6d58b8dR128)! My impression is that (outside a PaaS), setting environment variables is a pain, and varies widely. I want to give a better recommendation that I am right now.