Add special Abstract prefix not usage for PHPUnit test cases #8600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Nov 7, 2017
contributing/code/standards.rst
Outdated
| @@ -190,7 +190,7 @@ Naming Conventions | |||
|
|
|||
| * Use namespaces for all classes; | |||
|
|
|||
| * Prefix abstract classes with ``Abstract``. Please note some early Symfony classes | |||
| * Prefix all abstract classes with ``Abstract`` excepting PHPUnit ``*TestCase``. Please note some early Symfony classes | |||
greg0ire
reviewed
Nov 7, 2017
contributing/code/standards.rst
Outdated
| @@ -190,7 +190,7 @@ Naming Conventions | |||
|
|
|||
| * Use namespaces for all classes; | |||
|
|
|||
| * Prefix abstract classes with ``Abstract``. Please note some early Symfony classes | |||
| * Prefix all abstract classes with ``Abstract`` excepting PHPUnit ``*TestCase``. Please note some early Symfony classes | |||
There was a problem hiding this comment.
Please comply with the sf docs standards:
wouterj
approved these changes
Nov 12, 2017
|
Thanks @soullivaneuh! |
weaverryan
added a commit
that referenced
this pull request
Nov 12, 2017
…ses (Soullivaneuh) This PR was merged into the 3.3 branch. Discussion ---------- Add special Abstract prefix not usage for PHPUnit test cases As we can see here:  You are not using the `Abstract` prefix at all for the test cases. I assume this is to follow PHPUnit conventions on this part? In this case, the coding standard may be more accurate about this. Commits ------- f4d122a Add special Abstract prefix not usage for PHPUnit test cases
|
Just a note: I forgot to switch the branch to 2.7 on merge, but backported it manually. |
weaverryan
added a commit
that referenced
this pull request
Nov 12, 2017
* 2.7: Added Best Practice guideline for partials/include Backporting #8600 Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts"
weaverryan
added a commit
that referenced
this pull request
Nov 12, 2017
* 2.8: Added Best Practice guideline for partials/include Backporting #8600 Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts"
weaverryan
added a commit
that referenced
this pull request
Nov 12, 2017
* 3.3: Added Best Practice guideline for partials/include Backporting #8600 [#8605] Updated the article a little more, using the tests/ directory. fix paths Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts" Add special Abstract prefix not usage for PHPUnit test cases
weaverryan
added a commit
that referenced
this pull request
Nov 12, 2017
* 3.4: Added Best Practice guideline for partials/include Backporting #8600 [#8605] Updated the article a little more, using the tests/ directory. fix paths Move `schema_filter` option to the correct place Fix typo in "advanced ACL concepts" Add special Abstract prefix not usage for PHPUnit test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we can see here:
You are not using the
Abstractprefix at all for the test cases.I assume this is to follow PHPUnit conventions on this part?
In this case, the coding standard may be more accurate about this.