[Flex] Update routing & controller chapters #8592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 5, 2017
page_creation.rst
Outdated
| @@ -273,7 +285,7 @@ project: | |||
| ``src/`` | |||
| All your PHP code lives here. | |||
|
|
|||
| 99% of the time, you'll be working in ``src/`` (PHP files) or ``config/`` (everything | |||
| Most of the time, you'll be working in ``src/`` (PHP files) or ``config/`` (everything | |||
There was a problem hiding this comment.
Maybe we should remove this phrase entirely? You now have lots of dirs to work on (templates, translations, assets, ...) It's not true that most of the time you are in src/ and config/
controller.rst
Outdated
| via ``$this->get()`` or ``$this->container->get()``. This forces you to write | ||
| more robust code to access services. But if you *do* need direct access to the | ||
| container, using ``Controller`` is fine. | ||
| What's the difference between ``Controller`` or ``AbstractController``. Not much: |
There was a problem hiding this comment.
There's a missing ? at the end of this question.
controller.rst
Outdated
| more robust code to access services. But if you *do* need direct access to the | ||
| container, using ``Controller`` is fine. | ||
| What's the difference between ``Controller`` or ``AbstractController``. Not much: | ||
| both are identical, except that ``AbstractController`` is more restrictive: it |
There was a problem hiding this comment.
I don't like this AbstractController vs Controller thing :( For this introductory article is confusing and it forces the user to make a decision they cannot make at this point (because they know nothing about services and container and get(...)).
But at the same time this is probably the best place to talk about this ... so I'm really confused!
| @@ -64,9 +34,9 @@ class:: | |||
| class LuckyController | |||
| { | |||
| /** | |||
| * @Route("/lucky/number/{max}") | |||
| * @Route("/lucky/number/{max}", name="app_lucky_number") | |||
There was a problem hiding this comment.
Is this app_ prefix a good practice for route names? I'd never do that and it makes routes a bit long ... but if you consider it a good practice, then it's OK.
yceruto
reviewed
Nov 5, 2017
|
|
||
| $collection = new RouteCollection(); | ||
| $collection->add('blog_list', new Route('/blog', array( | ||
| '_controller' => 'AppBundle:Blog:list', | ||
| '_controller' => [BlogController::class, 'list'] |
routing.rst
Outdated
| controller. Along the way, you'll learn all sorts of tricks that make mapping | ||
| even the most complex URLs easy. | ||
| configure your routes in YAML, XML or PHP, that's no problem! Just create a | ||
| new routing file (e.g. ``routing.xml``) and Symfony will automatically use it. |
yceruto
reviewed
Nov 5, 2017
routing.rst
Outdated
|
|
||
| Having flexibility is even more important. What if you need to change the | ||
| URL of a page from ``/blog`` to ``/news``? How many links should you need to | ||
| URL of a page from ``/blog`` to ``/news``? How many links woud you need to |
weaverryan
added a commit
that referenced
this pull request
Dec 1, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8592). Discussion ---------- [Flex] Update routing & controller chapters More progress in updating all of the "Getting Started" guides. I will next do templating, configuration (though this has been done in #8588) and also `service_container`, which I'd like to move into Getting Started. Commits ------- 0cbbc28 fixing build errors 7f0163a tweaks 10563a9 Proofing the controller chapters 44f2ff8 more work on getting started docs 218e2d4 WIP controller chapter 8b923e6 WIP controller changes 89d56ea Updating routing for Flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More progress in updating all of the "Getting Started" guides. I will next do templating, configuration (though this has been done in #8588) and also
service_container, which I'd like to move into Getting Started.