Skip to content

Document new Monolog HTTP code exclusion feature #8235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix title underline length
  • Loading branch information
simshaun committed Apr 17, 2018
commit c9f6ee5ea5735d9ff6528872ade134ebef5616b8
2 changes: 1 addition & 1 deletion logging/monolog_exclude_http_codes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
single: Monolog; Exclude HTTP Codes

How to Configure Monolog to Exclude Specific HTTP Codes from the Log
===========================================================
====================================================================

Sometimes your logs become flooded with unwanted HTTP errors, for example,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a versionadded here:

..versionadded:: 4.1
    The ability to exclude status codes was introduced in Symfony 4.1 and MonologBundle 3.3.

I'm guessing on the 3.3 part for MonologBundle, but unless something super strange happens, that should be true.

403s and 404s. When using a ``fingers_crossed`` handler, you can exclude
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: is the mention of the fingers_crossed handler just an example or does this feature only work with that specific handler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I based the feature off of NotFoundActivationStrategy, which is only for fingers_crossed

Expand Down