Updated the Core Team information #8187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jul 18, 2017
contributing/code/core_team.rst
Outdated
|
|
||
| * **Maxime Steinhausser** (`ogizanagi`_) can merge into Config_, Console_, | ||
| Form_, Serializer_, DependencyInjection_, and HttpKernel_ components. | ||
|
|
||
| * **Deciders** (``@symfony/deciders`` on GitHub): | ||
|
|
||
| * **Jordi Boggiano** (`seldaek`_); | ||
| * **Lukas Kahwe Smith** (`lsmith77`_); |
xabbuh
reviewed
Jul 18, 2017
contributing/code/core_team.rst
Outdated
| They are no longer part of the Core Team, but we are very grateful for all their | ||
| Symfony contributions: | ||
|
|
||
| * **Bernhard Schussek** (`webmozart`_). |
xabbuh
reviewed
Jul 18, 2017
contributing/code/core_team.rst
Outdated
| the SecurityBundle_ bundle. | ||
|
|
||
| * **Robin Chalas** (`chalasr`_) can merge into the Console_ and Security_ | ||
| components and the SecurityBundle_ bundle. |
There was a problem hiding this comment.
this and the three entries above should end with a semicolon
xabbuh
reviewed
Jul 18, 2017
contributing/code/core_team.rst
Outdated
| @@ -69,9 +65,6 @@ Active Core Members | |||
| * **Kévin Dunglas** (`dunglas`_) can merge into the PropertyInfo_, | |||
| Serializer_ component; | |||
|
|
|||
| * **Abdellatif AitBoudad** (`aitboudad`_) can merge into the Translation_ | |||
| component; | |||
|
|
|||
| * **Jakub Zalas** (`jakzal`_) can merge into the DomCrawler_ component; | |||
|
It looks like @csarrazi is completely missing here. |
xabbuh
reviewed
Jul 18, 2017
contributing/code/core_team.rst
Outdated
| * **Grégoire Pineau** (`lyrixx`_) can merge into the Workflow_ component; | ||
|
|
||
| * **Ryan Weaver** (`weaverryan`_) can merge into the Security_ component and | ||
| the SecurityBundle_ bundle; |
There was a problem hiding this comment.
What about removing "bundle" here? It looks redundant.
There was a problem hiding this comment.
Probably because you need a unique identifier to differentiate the Security_ and SecurityBundle_ links further down
There was a problem hiding this comment.
I mean changing "[...] the SecurityBundle_ bundle;" to ”[...] the SecurityBundle_;". This is a bit like how we deal with interface names when using class roles in the rest of the documentation.
xabbuh
reviewed
Jul 18, 2017
contributing/code/core_team.rst
Outdated
| the SecurityBundle_ bundle; | ||
|
|
||
| * **Robin Chalas** (`chalasr`_) can merge into the Console_ and Security_ | ||
| components and the SecurityBundle_ bundle; |
xabbuh
approved these changes
Jul 18, 2017
|
Thank you @javiereguiluz. |
|
Welcome @chalasr, @ogizanagi and @csarrazi! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated according to https://symfony.com/blog/symfony-core-team-updates