Add new symfony4 site type to homestead documentation #8078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 22, 2017
setup/homestead.rst
Outdated
| The ``type`` option tells Homestead to use the Symfony nginx configuration. | ||
| The ``type`` option tells Homestead to use the Symfony nginx configuration. | ||
| Homestead now supports a Symfony2 web layout with app.php and app_dev.php when | ||
| using type: symfony2 and an index.php layout when using type: symfony4. |
There was a problem hiding this comment.
What happens when the symfony layout (with neither 2 nor 4) is used as it was before?
There was a problem hiding this comment.
When symfony is used it defaults to serve_symfony2.sh configuration (this hasn't changed). I added the symfony2 for clarity when discussing the new symfony4 type.
javiereguiluz
requested changes
Jul 6, 2017
xabbuh
approved these changes
Sep 6, 2017
javiereguiluz
approved these changes
Sep 6, 2017
wouterj
added a commit
that referenced
this pull request
Nov 13, 2017
Merged
wouterj
added a commit
that referenced
this pull request
Nov 13, 2017
|
Hi @michaelesmith! I've rebased your PR on the 4.0 version of the docs and added some minor inline code blocks in a seperate commit. This is now merged with PR #8640. You'll still receive your credits for your nice work! Thanks for documenting this new homestead feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new site type was added in laravel/homestead#600 for index.php only configurations. This pr adds this information to the homestead documentation.