Update cache_pools.rst #7451
Merged
Update cache_pools.rst #7451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving an item from cache you have to use `getItem()` and not `get()` The `Psr\Cache\CacheItemPoolInterface` doesn't declare the `get` method
xabbuh
requested changes
Feb 7, 2017
| @@ -282,7 +282,7 @@ item in the cache immediately (it returns ``true`` if the item was saved or | |||
| ``false`` if some error occurred):: | |||
|
|
|||
| // ... | |||
| $userFriends = $cache->get('user_'.$userId.'_friends'); | |||
| $userFriends = $cache->getItem('user_'.$userId.'_friends'); | |||
There was a problem hiding this comment.
We now also need to call get() on the return value (the cache pool does not return the cached value, but a CacheItemInterface instance).
There was a problem hiding this comment.
It's just about saving cache items.
I don't think it is necessary to get the value if you just want to save the value into cache.
There was a problem hiding this comment.
Ah indeed, I misread the following code.
|
Good catch, thanks @crislinu. |
xabbuh
added a commit
that referenced
this pull request
Feb 19, 2017
This PR was merged into the 3.2 branch. Discussion ---------- Update cache_pools.rst When retrieving an item from cache you have to use `getItem()` and not `get()` The `Psr\Cache\CacheItemPoolInterface` doesn't declare the `get` method Commits ------- 398892e Update cache_pools.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving an item from cache you have to use
getItem()and notget()The
Psr\Cache\CacheItemPoolInterfacedoesn't declare thegetmethod