[DependencyInjection][Fix] Missing RequestStack #7447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, Since the 2.8 the RouterListener object needs the RequestStack object for the second argument. As you may notice it is missing in the following example: - http://symfony.com/doc/current/create_framework/dependency_injection.html Regards,
|
👍 Status: Reviewed |
|
Hello @javiereguiluz, Do you approve of this PR? Regards, |
javiereguiluz
approved these changes
Feb 13, 2017
|
Thank you @20uf. |
xabbuh
added a commit
that referenced
this pull request
Feb 19, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [DependencyInjection][Fix] Missing RequestStack Hello, Since the 2.8 the RouterListener object needs the RequestStack object for the second argument. It was optional until version 3.0, eg: - http://api.symfony.com/2.8/Symfony/Component/HttpKernel/EventListener/RouterListener.html - http://api.symfony.com/3.0/Symfony/Component/HttpKernel/EventListener/RouterListener.html As you can see, it lacks in the following example and causes a significant error: - http://symfony.com/doc/current/create_framework/dependency_injection.html Regards, Commits ------- 823b3b0 [DependencyInjection][Fix] Missing RequestStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since the 2.8 the RouterListener object needs the RequestStack object for the second argument.
It was optional until version 3.0, eg:
As you can see, it lacks in the following example and causes a significant error:
Regards,