Minor improvements for the contribution guide #7053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Oct 14, 2016
…luz) This PR was merged into the 2.7 branch. Discussion ---------- Minor improvements for the contribution guide Changing `<YOUR GITHUB USERNAME>` to `YOUR-GITHUB-USERNAME` is needed because otherwise our terminal lexer considers it a Windows prompt in some cases:  I don't think it's worth it to try to fix this in the lexer. Commits ------- e8e98cc Minor improvements for the contribution guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
<YOUR GITHUB USERNAME>toYOUR-GITHUB-USERNAMEis needed because otherwise our terminal lexer considers it a Windows prompt in some cases:I don't think it's worth it to try to fix this in the lexer.