Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Form Types location contradicts Best Practices #6733

Merged
merged 1 commit into from
Jul 8, 2016
Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 8, 2016

Rebase of #6266

I wondered why I always put form definitions in `AppBundle/Form/Type`, and whether we were meant to put something else in `AppBundle/Form`. While Googling for an answer I came across http://symfony.com/doc/current/best_practices/forms.html which says the new best practice is to put the form types (which I guess are usually form definitions) directly in `AppBundle/Form`.

This PR updates the [main documentation ](http://symfony.com/doc/current/book/forms.html#book-form-creating-form-classes) to reflect the best practices. If anyone can point me to discussions clarifying the difference between form types, form definitions and how the Symfony view has changed (reflected in the change of location) I'd greatly appreciate it.
@wouterj wouterj merged commit f9597a6 into 2.7 Jul 8, 2016
wouterj added a commit that referenced this pull request Jul 8, 2016
…yer)

This PR was merged into the 2.7 branch.

Discussion
----------

[DX] Form Types location contradicts Best Practices

Rebase of #6266

Commits
-------

f9597a6 [DX] Form Types location contradicts Best Practices
@wouterj wouterj deleted the pbowyer-patch-3 branch July 8, 2016 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants