[PropertyAccess] Custom methods on property accesses

[lrlopez]

Q	A
Doc fix?	no
New docs?	symfony/symfony#22190
Applies to	Property access
Fixed tickets	None

[lrlopez]

Guys, just a quick question. I was expecting a plataformsh automatic documentation deploy of this PR but found none. Has the feature been discontinued or am I just doing something wrong?

[xabbuh]

This seems to be a general issue with Platform.sh. @GuGuss can you help us here (this seems to affect all recent pull requests)?

[javiereguiluz]

Minor syntax issue: in Markdown you can use this:

`getter`, `setter`, `adder` and `remover`

but in RST you must use double backticks:

``getter``, ``setter``, ``adder`` and ``remover``

[javiereguiluz]

@lrlopez this is truly a useful feature. I hope it's included in Symfony soon! Thank you also for providing the docs for the feature.

[lrlopez]

@javiereguiluz Thank you very much for the review!

[lrlopez]

All comments have been addressed

[lrlopez]

Docs ready for final review!

[GuGuss]

@lrlopez @xabbuh I'm not sure why we face long delays sometimes between automated PR deployments. The PR has now been deployed without me doing anything :)

[lrlopez]

Docs have been rebased to latest master so no conflicts arise anymore. By the way, related PR are now symfony/symfony#22190 and symfony/symfony#22191

[HeahDude]

Thanks for documenting this awesome feature :)

[HeahDude]

This needs a .. versionadded:: directive.

[lrlopez]

Should I target 3.3 or 3.4? I think is 3.4, but I'd like to be sure

[HeahDude]

It does make sense to name the annotation class PropertyAccess but maybe it is worth an alias, wdyt?

[lrlopez]

Hmmm... I've been thinking all the day around about renaming the annotation class to Accessor. Do you think is better?

[HeahDude]

Maybe, but it would not be that consistent with the other, so what about:

/**
 * @PropertyAcessor(...)
 */
private $property;

/**
 * @GetterAccessor(...)
 */
public function propertyState()
{
    // ...
}

/**
 * @SetterAccessor(...)
 */
public function updateProperty()
{
    // ...
}

/**
 * @AdderAccessor(...)
 */
public function increaseProperty(Arg $arg)
{
    // ...
}

/**
 * @RemoverAccessor(...)
 */
public function decreaseProperty(Arg $arg)
{
    // ...
}

WDYT?

[lrlopez]

Ok, let's do this way then! We can change later them if we don't like the results...

[lrlopez]

@HeahDude, we could rename this annotation to just Getter and do the same to the others (Setter, Adder and Remover). Do you agree?

[HeahDude]

It seems I've answered above at the same time :). I don't know what's best though.

[lrlopez]

Although it may not be needed, I've squashed the commits.

[OskarStark]

Code PR closed