Skip to content

[HttpFoundation] ParameterBag::get() $deep param #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Oliboy50
Copy link
Contributor

@Oliboy50 Oliboy50 commented Mar 6, 2016

Q A
Doc fix? yes
New docs? no
Applies to 2.8+

Documentation replacement for $deep parameter of ParameterBag::get() since it was deprecated in 2.8 and removed in 3.0.

Because there's no need to show the legacy way of doing this. We just get an array back and that's all.

@javiereguiluz
Copy link
Member

👍 I agree completely with you. Thanks @Oliboy50.

I have a minor suggestion though. Don't you think that the original example is a bit confusing because of this: ?foo[bar]=bar The bar string is repeated, so when the example says returns 'bar' you don't know if it's returning the key or the value. Maybe we should replace it by ?foo[bar]=baz ?

@javiereguiluz
Copy link
Member

@Oliboy50 I've created #6390 to finish this PR. You work was great but we wanted to make a final change. To avoid letting pull requests "die", from time to time we take over pending PRs to finish them. Of course I reused your original commit, so you'll get full credit for your work once this is merged. Thanks!

@Oliboy50
Copy link
Contributor Author

thanks, @javiereguiluz I was waiting for a comment on this PR, but I didn't receive a mail for your comment 11days ago... so I though nobody answered it, my bad

anyway, I completely agree with all you said/done, so thanks a lot :)

@Oliboy50 Oliboy50 closed this Mar 20, 2016
@Oliboy50 Oliboy50 deleted the patch-2 branch March 20, 2016 20:04
xabbuh added a commit that referenced this pull request Mar 26, 2016
…guiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Reworded the example about $deep param

This finishes #6333.

Commits
-------

09bc39e Reworded the example about $deep param
f82b32e [HttpFoundation] ParameterBag::get() $deep param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants