Skip to content

Warn on issue with controllers-as-services versus @Route annotation #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Warn on issue with controllers-as-services versus @Route annotation #6258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cookbook/controller/service.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ Then you can define it as a service as follows:
'AppBundle\Controller\HelloController'
));

.. caution::

If you are managing your routes with PHP annotation, you may need to add an
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a may. It is always needed (otherwise the controller is not used as a service)

``@Route`` annotation to the controller-class which specifies its service
ID. If you don't, the system may try to construct your controller without
any arguments. See the `FrameworkExtraBundle documentation`_ for details.

Referring to the Service
------------------------

Expand Down