-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in When Things Get More Advanced #6070
Conversation
Fixed `{id}` to `{postSlug}` to match the code example.
The "it" is refering to the parameter name in the section above it (about paramconverter). It tells you that this code works, as the parameter name equals the property name. Then it shows an example which doesn't work nicely, because parameter name doesn't equal the property name (postSlug in this case). |
@wouterj |
@BallisticPain Actually, the section as it is right now is technically correct. Though as you were confused by how it is written right now we can maybe improve this part. Do you have an idea how we could rewrite this to make it easier to understand? |
Maybe we can reword a bit the first phrase of the When Things Get More Advanced section: -This works without any configuration because the wildcard name ``{id}`` matches [...]
+The above example works without any configuration because the wildcard name
+ ``{id}`` matches [...] |
sounds good |
That does sound good to me too. Would you like me to modify? |
👍 |
Thank you @BallisticPain. |
Happy to be of assistance. I think it's soo exciting to contribute to open-source projects! |
Fixed
{id}
to{postSlug}
to match the code example.