Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in When Things Get More Advanced #6070

Closed
wants to merge 2 commits into from

Conversation

BallisticPain
Copy link
Contributor

Fixed {id} to {postSlug} to match the code example.

Fixed `{id}` to `{postSlug}` to match the code example.
@wouterj
Copy link
Member

wouterj commented Dec 23, 2015

The "it" is refering to the parameter name in the section above it (about paramconverter). It tells you that this code works, as the parameter name equals the property name. Then it shows an example which doesn't work nicely, because parameter name doesn't equal the property name (postSlug in this case).

@BallisticPain
Copy link
Contributor Author

@wouterj
Are you just informing me, or asking me to make a change to my commit in order to get this approved?

@xabbuh
Copy link
Member

xabbuh commented Dec 23, 2015

@BallisticPain Actually, the section as it is right now is technically correct. Though as you were confused by how it is written right now we can maybe improve this part. Do you have an idea how we could rewrite this to make it easier to understand?

@javiereguiluz
Copy link
Member

Maybe we can reword a bit the first phrase of the When Things Get More Advanced section:

-This works without any configuration because the wildcard name ``{id}`` matches [...]
+The above example works without any configuration because the wildcard name
+ ``{id}`` matches [...]

@xabbuh
Copy link
Member

xabbuh commented Jan 11, 2016

sounds good

@BallisticPain
Copy link
Contributor Author

That does sound good to me too. Would you like me to modify?
Apologies for the delay. Holidays and I forgot... ;)

@wouterj
Copy link
Member

wouterj commented Jan 20, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented Jan 20, 2016

Thank you @BallisticPain.

xabbuh added a commit that referenced this pull request Jan 20, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6070).

Discussion
----------

Typo in When Things Get More Advanced

Fixed `{id}` to `{postSlug}` to match the code example.

Commits
-------

2f98e97 Typo in When Things Get More Advanced
@xabbuh xabbuh closed this Jan 20, 2016
@BallisticPain
Copy link
Contributor Author

Happy to be of assistance. I think it's soo exciting to contribute to open-source projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants