Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the profiler matchers article #5593

Closed

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

Minor reword to expand some explanations and suggested to make the matcher service private.

@stof
Copy link
Member

stof commented Aug 3, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Aug 4, 2015

👍

wouterj added a commit that referenced this pull request Aug 20, 2015
This PR was squashed before being merged into the 2.3 branch (closes #5593).

Discussion
----------

Updated the profiler matchers article

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | -

Minor reword to expand some explanations and suggested to make the matcher service private.

Commits
-------

dede183 Updated the profiler matchers article
@wouterj
Copy link
Member

wouterj commented Aug 20, 2015

Thank you @javiereguiluz! Merged it in now.

I've completed the XML config blocks and made a little wording fix in 6c76b2b

@wouterj wouterj closed this Aug 20, 2015
weaverryan added a commit that referenced this pull request Aug 21, 2015
* 2.3:
  Reset some more pygments styles
  Use pip instead of submodules
  Use numbered code block
  Add demo warning
  Move Sphinx files to _theme
  Update config
  Use a more recent version of Sphinx
  Temporary disable codeblock
  Use symfony.com theme on Platform.sh builds
  Update page_creation.rst
  [#5593] Very little rewording and improving config
  Updated the profiler matchers article
  don't override existing variables
  [Cookbook][Session] fix default expiry field name
  Fix code
weaverryan added a commit that referenced this pull request Aug 21, 2015
* 2.7:
  Reset some more pygments styles
  Use pip instead of submodules
  Use numbered code block
  Add demo warning
  Move Sphinx files to _theme
  Update config
  Use a more recent version of Sphinx
  Temporary disable codeblock
  Use symfony.com theme on Platform.sh builds
  Update page_creation.rst
  [#5593] Very little rewording and improving config
  Updated the profiler matchers article
  don't override existing variables
  [Cookbook][Session] fix default expiry field name
  Fix code
weaverryan added a commit that referenced this pull request Aug 21, 2015
* 2.8:
  Reset some more pygments styles
  Use pip instead of submodules
  Use numbered code block
  Add demo warning
  Move Sphinx files to _theme
  Update config
  Use a more recent version of Sphinx
  Temporary disable codeblock
  Use symfony.com theme on Platform.sh builds
  Update page_creation.rst
  [#5593] Very little rewording and improving config
  Updated the profiler matchers article
  don't override existing variables
  [Cookbook][Session] fix default expiry field name
  Fix code
@javiereguiluz javiereguiluz deleted the tweak_profiler_matcher branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants