Skip to content

Update the_controller.rst #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update the_controller.rst #5181

wants to merge 1 commit into from

Conversation

aykin
Copy link

@aykin aykin commented Apr 15, 2015

The sample code does not work due to an array o string conversion exception. The documentation needs to be updated to reflect the change

The sample code does not work due to an array o string conversion exception. The documentation needs to be updated to reflect the change
@wouterj
Copy link
Member

wouterj commented Apr 16, 2015

What do you think of updating this with:

{% for flashMessage in app.session.flashbag.get('notice') %}
    <div class="flash-notice">
        {{ flashMessage }}
    </div>
{% endfor %}

(which is the example shown in the book)

@stof
Copy link
Member

stof commented Apr 16, 2015

much better. The code suggested by @aykin would break when there is no notice message

@aykin
Copy link
Author

aykin commented Apr 17, 2015

I agree. Though I think it might be a bit too heavy for this section of the document. Perhaps an bare unordered list (without a style class) would be more suitable?

@wouterj
Copy link
Member

wouterj commented Apr 26, 2015

I think the example isn't that heavy. An unordered list (while being more semantic) would require even more loc :)

@javiereguiluz
Copy link
Member

I'm finishing this PR in #5431.

@aykin don't worry about not having finished your PR. This happens sometimes. I've taken your work and finished it in another PR. I've also reused all your original commits so you get full credit for your work. Thanks.

@xabbuh xabbuh closed this Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants