Skip to content

Fix typos #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2015
Merged

Fix typos #4885

merged 2 commits into from
Mar 13, 2015

Conversation

ifdattic
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets

@ifdattic
Fix typos
5744623 
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |
wouterj
wouterj reviewed Jan 31, 2015
View reviewed changes
cookbook/form/form_collections.rst
@@ -459,7 +459,7 @@ is added to the ``Task`` class by calling the ``addTag`` method. Before this
change, they were added internally by the form by calling ``$task->getTags()->add($tag)``.
That was just fine, but forcing the use of the "adder" method makes handling
these new ``Tag`` objects easier (especially if you're using Doctrine, which
we talk about next!).
we will talk about next!).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, while you're doing this, can you please also remove the usage of the first person from this sentence? E.g. "especially if you're using Doctrine, which you will learn about next!)"

@xabbuh
Copy link
Member

xabbuh commented Mar 8, 2015

👍

@weaverryan
Copy link
Member

Easy win! Thanks Andrew!

@weaverryan weaverryan merged commit c3ef622 into symfony:2.3 Mar 13, 2015
weaverryan added a commit that referenced this pull request Mar 13, 2015
@weaverryan
minor #4885 Fix typos (ifdattic)
a444220 
This PR was merged into the 2.3 branch.

Discussion
----------

Fix typos

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |

Commits
-------

c3ef622 Remove usage of first person
5744623 Fix typos
@ifdattic ifdattic deleted the patch-11 branch March 13, 2015 12:01
@ifdattic
Copy link
Contributor Author

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ifdattic @xabbuh @weaverryan @wouterj