-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Complete rewrote FrameworkBundle config reference #4736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cd6ee13
Rewrote FrameworkBundle configuration reference
wouterj e19cd05
Removed config dump
wouterj 5ee19ed
lowercase
wouterj b560fab
Added message from #5008
wouterj d9b1a08
Most recent Phpstorm version natively file links
ericroge 90c9ac0
Added tip for windows devs
wouterj b037d8c
Applied the easier comments
wouterj bb9a1e7
Some final fixes
wouterj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Removed config dump
- Loading branch information
commit e19cd05d0e4a7050ab1d3a9e5dd3ee7b75e39ea5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do still think the full big tree of configuration is useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funny you say this, as you were the one against it a couple of years back :) I've not yet removed it (will do in another PR), so we can discuss it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha! I totally believe that. I was looking at some of my comments in a different issue from January of this year and have no memory of making them :).