Update NotBlank to reflect the actual validation #4615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As can be seen in the [validator][1] class values that are false also lead to a violation. This was not documented, which we discovered when using this constraint 😉 [1]: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Validator/Constraints/NotBlankValidator.php#L34
Member
|
Great catch and explanation - thanks @DRvanR! |
weaverryan
added a commit
that referenced
this pull request
May 22, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #4615). Discussion ---------- Update NotBlank to reflect the actual validation | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | n/a As can be seen in the [validator][1] class values that are false also lead to a violation. This was not documented, which we discovered when using this constraint 😉 [1]: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Validator/Constraints/NotBlankValidator.php#L34 Commits ------- b11ad2e Update NotBlank to reflect the actual validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen in the validator class values that are false also lead to a violation. This was not documented, which we discovered when using this constraint 😉