Completed the needed context to successfully test commands with Helpers #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -254,6 +254,9 @@ from the command line, you need to overwrite the HelperSet used by the command:: | |||
| public function testExecute() | |||
| { | |||
| // ... | |||
| $application = new Application(); | |||
There was a problem hiding this comment.
whats about the use statements?
| @@ -279,3 +284,7 @@ By setting the input stream of the ``DialogHelper``, you imitate what the | |||
| console would do internally with all user input through the cli. This way | |||
| you can test any user interaction (even complex ones) by passing an appropriate | |||
| input stream. | |||
|
|
|||
| .. seealso:: | |||
There was a problem hiding this comment.
You should add a blank line between the directive and the text.
|
Updated. |
| @@ -411,6 +411,8 @@ tools capable of helping you with different tasks: | |||
| * :doc:`/components/console/helpers/tablehelper`: displays tabular data as a table | |||
| * :doc:`/components/console/helpers/dialoghelper`: (deprecated) interactively ask the user for information | |||
|
|
|||
| .. _book-console-testing-commands: | |||
There was a problem hiding this comment.
components-console-testing-commands would fit better.
|
Once more.. updated. |
|
Yes, it is. Thank you @peterrehm ! |
| @@ -247,13 +247,18 @@ Testing a Command which Expects Input | |||
| If you want to write a unit test for a command which expects some kind of input | |||
| from the command line, you need to overwrite the HelperSet used by the command:: | |||
|
|
|||
| use Symfony\Bundle\FrameworkBundle\Console\Application; | |||
There was a problem hiding this comment.
I think we should not use the Application class from the FrameworkBundle in the components section, but use the Symfony\Component\Console\Application class instead.
|
@peterrehm We just have to fix the namespace in the |
|
Updated. |
|
And in the end, the PR can be merged. Thanks for your patience and good job, Peter! |
wouterj
added a commit
that referenced
this pull request
Dec 28, 2014
…with Helpers (peterrehm) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4582). Discussion ---------- Completed the needed context to successfully test commands with Helpers | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4581 As mentioned in symfony/symfony#12798 the explanation about the initialization is not clear. Therefore I have added the needed context and a reference to the related cookbook article. Commits ------- a94bd71 Completed the needed context to successfully test commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in symfony/symfony#12798 the explanation about the initialization is not clear.
Therefore I have added the needed context and a reference to the related cookbook article.