[WCM] Idle sessions expiration cookbook recipe. #4576
Conversation
ajgarlag
commented
Dec 2, 2014
ajgarlag
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (PR symfony/symfony#12807) |
| Applies to | 2.7 |
| Fixed tickets |
|
@ajgarlag Thank you for the pull request. FYI, I have added [WCM] to the title which means "Waiting Code Merge". |
xabbuh
changed the title
| .. index:: | ||
| single: Security; Expiration of idle sessions | ||
|
|
||
| Expiration of idle sessions |
There was a problem hiding this comment.
Should be "Expiration of Idle Sessions" according to our headline capitalization rules (capitalize all words expect of close class words).
| ), | ||
| )); | ||
|
|
||
|
|
There was a problem hiding this comment.
You have a double empty line here. Could you please remove one of them?
|
Thank you for submitting such detailed docs while doing a PR on the code, @ajgarlag! I've left some comments. |
|
Thank you for reviewing it. I hope this can help to merge the PR soon. |
| .. index:: | ||
| single: Security; Expiration of Idle sessions | ||
|
|
||
| Expiration of Idle sessions |
|
|
||
| .. code-block:: yaml | ||
|
|
||
| # app/config/security.yml |
There was a problem hiding this comment.
# config/packages/security.yaml instead of # app/config/security.yml
|
|
||
| .. code-block:: xml | ||
|
|
||
| <!-- app/config/security.xml --> |
There was a problem hiding this comment.
# config/packages/security.xml
|
|
||
| .. code-block:: php | ||
|
|
||
| // app/config/security.php |
There was a problem hiding this comment.
# config/packages/security.php
| http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
|
|
||
| <config> | ||
| <firewall> |
There was a problem hiding this comment.
I think you forgot here the firewall name
|
|
||
| .. code-block:: yaml | ||
|
|
||
| # app/config/security.yml |
There was a problem hiding this comment.
# config/packages/security.yaml here
|
I'm closing this one because the related code PR was closed recently. Sorry! |
