Skip to content

Deploy Symfony application on Platform.sh. #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Deploy Symfony application on Platform.sh. #4526

wants to merge 11 commits into from

Conversation

GuGuss
Copy link

@GuGuss GuGuss commented Nov 28, 2014

No description provided.

Once your project is ready, give it a name and choose: **Create a new site**.
Choose the *Symfony* stack and a starting point such as *Standard*.

That's it! Your Symfony application will be bootstaped and deployed. You'll soon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstaped -> bootstrapped

@pborreli
Copy link
Contributor

👍

@GuGuss
Copy link
Author

GuGuss commented Nov 28, 2014

@pborreli Thanks !

.. _`Platform.sh documentation`: https://docs.platform.sh/toolstacks/symfony/symfony-getting-started
.. _`Platform.sh project`: https://marketplace.commerceguys.com/platform/buy-now
.. _`Platform.sh configuration files`: https://docs.platform.sh/reference/configuration-files
.. _`Github`: https://github.com/platformsh/platformsh-examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Github -> GitHub

$container->setParameter('database_path', '');
}

# Hack.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the "#Hack" comment or find a solution :)

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2014

@GuGuss Nice addition! I have left some minor comments.

@GuGuss
Copy link
Author

GuGuss commented Nov 29, 2014

Thanks guys for the review.

This should make the Travis build pass.
@GuGuss GuGuss changed the title Deploy Symfony application on Platform.sh. [Ready to be merged] Deploy Symfony application on Platform.sh. Dec 3, 2014
To deploy your Symfony application on Platform.sh, you simply need to add a
``.platform.app.yaml`` at the root of your Git repository which will tell
Platform.sh how to deploy your application (read more about `Platform.sh
configuration files`_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're used to put roles on the same line. So could you add a linebreak before ``Platform.sh configuration files_ please?

.. code-block:: yaml

# .platform.app.yaml
# This file describes an application. You can have multiple applications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standards state that there should be an empty line between a file comment and a normal comment.

@GuGuss
Copy link
Author

GuGuss commented Dec 9, 2014

Thanks again guys for your review. I think this is ready to go ^^

@GuGuss
Copy link
Author

GuGuss commented Dec 15, 2014

Hi guys, any update on this PR?

@javiereguiluz
Copy link
Member

@GuGuss thanks for submitting this article and for adding all the improvements suggested by the reviewers.

@xabbuh @wouterj in my opinion this PR is ready to be labelled as finished and to be merged soon. What do you think?

@xabbuh
Copy link
Member

xabbuh commented Dec 19, 2014

@GuGuss You also have to add a reference to the new document in /cookbook/map.rst.inc.

After that, I think this is ready to be merged. Really nice document! 👍

@GuGuss
Copy link
Author

GuGuss commented Dec 24, 2014

Done ! Thanks guys !

@xabbuh
Copy link
Member

xabbuh commented Dec 24, 2014

👍

@GuGuss GuGuss changed the title [Ready to be merged] Deploy Symfony application on Platform.sh. Deploy Symfony application on Platform.sh. Dec 24, 2014
@weaverryan
Copy link
Member

I'm trusting that all the specs and details are there, but I think that's ok since this is coming straight from you guys @GuGuss :). This reads really well - I'm happy to merge it in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants