Skip to content

replace "Symfony2" with "Symfony" #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2014
Merged

replace "Symfony2" with "Symfony" #4205

merged 1 commit into from
Sep 15, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 5, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #4203

@javiereguiluz
Copy link
Member

@xabbuh beware that if we change any title of any section, links will be broken. For internal anchors is not that important I guess, but for the title of the chapters, this would be a big problem. Example: https://github.com/symfony/symfony-docs/pull/4205/files#diff-7c476141c8e94caded7e7fc0707ff263R1

stof
stof reviewed Sep 5, 2014
View reviewed changes
contributing/code/patches.rst
@@ -402,7 +402,7 @@ messages of all the commits. When you are finished, execute the push command.
.. _ProGit: http://git-scm.com/book
.. _GitHub: https://github.com/signup/free
.. _`GitHub's Documentation`: https://help.github.com/articles/ignoring-files
.. _Symfony2 repository: https://github.com/symfony/symfony
.. _Symfony repository: https://github.com/symfony/symfony
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should fix the alignment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I even don't like those kind of alignment at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is also why I hate aligning = and => in code. But if the alignment is used, it should be respected

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. I'm currently adding labels for the changed headlines and will fix the alignment here then.

@xabbuh
Copy link
Member Author

xabbuh commented Sep 5, 2014

@javiereguiluz Hm, that's true. How do we deal with this? Could adding explicit labels with the outdated headline be an option?

@xabbuh
Copy link
Member Author

xabbuh commented Sep 5, 2014

I added labels for all modified headlines.

@stof stof mentioned this pull request Sep 13, 2014
Merged
@weaverryan
Copy link
Member

WOW, another HUGE PR. Amazing - thanks @xabbuh!

@weaverryan weaverryan mentioned this pull request Sep 15, 2014
Closed
@weaverryan weaverryan merged commit 3ba3d27 into symfony:2.3 Sep 15, 2014
weaverryan added a commit that referenced this pull request Sep 15, 2014
@weaverryan
minor #4205 replace "Symfony2" with "Symfony" (xabbuh)
f276e34 
This PR was merged into the 2.3 branch.

Discussion
----------

replace "Symfony2" with "Symfony"

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4203

Commits
-------

3ba3d27 replace "Symfony2" with "Symfony"
@xabbuh xabbuh deleted the issue-4203 branch September 15, 2014 15:14
@xabbuh xabbuh mentioned this pull request Nov 24, 2014
Closed
@xabbuh xabbuh mentioned this pull request Dec 14, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @javiereguiluz @weaverryan @stof @wouterj