Moved 'contributing' images to their own directory #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest adding a small note in the doc about contributing to the documentation saying that images should not be placed in |
|
@stof let's first find out if this solves the issue. |
|
Ok, let's see what happens! |
weaverryan
added a commit
that referenced
this pull request
Sep 15, 2014
…reguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Moved 'contributing' images to their own directory | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #3192 The PDF version of the "Contributing Guide" doesn't show the images (as reported in #3192). The rest of the PDFs correctly show them. Although I don't know the exact cause of the error, the "Contributing" guide images weren't stored in their own subdirectory inside `images/` and named after the book. That's the only difference between the right and the wrong PDF files. For compatibility reasons I've left on purpose the original images at their location and just made a copy in the new directory. Commits ------- fc15b65 Moved 'contributing' images to their own directory
|
This didn't seem to fix the issue. :( The images are still not included (and yes, the PDF has been regenerated after the merge of this pull request). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PDF version of the "Contributing Guide" doesn't show the images (as reported in #3192). The rest of the PDFs correctly show them. Although I don't know the exact cause of the error, the "Contributing" guide images weren't stored in their own subdirectory inside
images/and named after the book. That's the only difference between the right and the wrong PDF files.For compatibility reasons I've left on purpose the original images at their location and just made a copy in the new directory.