Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Github teams for the core team #4002

Merged
merged 1 commit into from
Aug 16, 2014

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jul 7, 2014

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets n/a

@@ -59,7 +59,7 @@ Active Core Members
HttpFoundation_, HttpKernel_, Serializer_, Stopwatch_, DoctrineBridge_,
MonologBridge_, and TwigBridge_ components.

* **Deciders**:
* **Deciders** (``@symfony/deciders`` on Github):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

puting it here is confusing IMO: the decider team includes the whole core team (as mergers are also deciders), not only the list below this title

@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2014

Will @symfony/mergers and @symfony/deciders then be somehow visible on GitHub later on?

@stof
Copy link
Member

stof commented Jul 7, 2014

@xabbuh AFAIK, teams are only visible for their members on github. I don't think there is a way to mark a team as public.

@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2014

@stof I see. But, does it then have any value to add this information?

@stof
Copy link
Member

stof commented Jul 7, 2014

yeah, because you can ping teams on github

@wouterj
Copy link
Member

wouterj commented Jul 7, 2014

E.g. ping @symfony/team-symfony-docs will ping ryan, fabian and me.

@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2014

Alright, the issue is that this behaviour is not really obvious since you can't check if such a team does exist when you are not a member of it. Maybe it's better to add a short explanation for that.

@weaverryan weaverryan merged commit 9e1f05e into symfony:2.3 Aug 16, 2014
weaverryan added a commit that referenced this pull request Aug 16, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

added Github teams for the core team

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets | n/a

Commits
-------

9e1f05e added Github teams for the core team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants