[Cookbook] Added note to deployment tools about exporting SYMFONY_ENV #4001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue (https://github.com/symfony/symfony-standard/issues/662) on symfony-standard.
jasonbouffard
changed the title
| @@ -97,6 +97,11 @@ as you normally do: | |||
| ensures that development packages are not installed in the production | |||
| environment. | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
what do you think of changing this to .. caution::?
|
This PR needs to be rebased (if you don't know what that is, we'll explain it to you) |
|
I think it would be helpful to also provide some information on how one would notice that they need to set the environment variable. |
| .. note:: | ||
|
|
||
| You may need to pass the environment name via ``export SYMFONY_ENV=prod`` | ||
| for the Symfony ``post-install-cmd`` commands to execute properly. |
There was a problem hiding this comment.
Why not be even more specific? Something like:
If you get a "class not found" error during this step, you may need to
run ``export SYMFONY_ENV=prod`` before running this command so that
the ``post-install-cmd`` scripts run in the ``prod`` environment.
There was a problem hiding this comment.
👍 That's what I had in mind when I wrote the comment. Though I would split this into two sentences.
Adds an example on how to configure multiple recipients in Monolog for sending log entries as e-mails.
… config (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Logging] add missing Monolog handler type in XML config | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Omitting the type of a handler leads to an error: > Symfony\Component\Config\Definition\Exception\InvalidConfigurationException: The child node "type" at path "monolog.handlers.swift" must be configured. Commits ------- dc33b0c add missing Monolog handler type in XML config
…figuration chapter (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Configuration] tweaks for the web server configuration chapter | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | Tweaks to #3915 as suggested by @weaverryan. Commits ------- 93bbd14 tweaks for the web server configuration chapter
…ehm) This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4150). Discussion ---------- Added the schema_filter option to the reference | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | ? | Fixed tickets | - Shall the optional setting be added to XML as well? How? I am unsure if it is actually to which version this relates to the DoctrineBundle. Relates to doctrine/migrations#101 Commits ------- 20cba4e Added the schema_filter option to the reference
… configs (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Logging] document multiple recipients in XML configs | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/monolog-bundle#91) | Applies to | all | Fixed tickets | #3940, #4135 Commits ------- 37ab23d document multiple recipients in XML configs
This PR was merged into the 2.3 branch.
Discussion
----------
Fix documentation for group_sequence_provider
The current documentation for `group_sequence_provider` option in the docs is wrong.
It states that the option should be set with:
```YAML
Your\Class\Name:
group_sequence_provider: ~
...
````
But this didn't work.
By looking at the unit test I came up the the right version:
```YAML
Your\Class\Name:
group_sequence_provider: true
...
````
Commits
-------
81cec5d Fix documentation for group_sequence_provider
`attr` is a quite useful option, but not yet listed here. BTW, the `attr.rst.inc` file already includes an `attr` conf. example concerning textareas.
…uilloux) This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4152). Discussion ---------- Adding 'attr' option to the Textarea options list | Q | A | ------------- | --- | Doc fix? | yes | New docs? | nope | Applies to | all? | Fixed tickets | ? `attr` is a quite useful option, but not yet listed here, so I added it. BTW, the `attr.rst.inc` file already includes an `attr` conf. example concerning textareas. Commits ------- d6f9bd1 Adding 'attr' option to the Textarea options list
This PR was merged into the 2.3 branch. Discussion ---------- Fixed minor typos. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all (or 2.3+) | Fixed tickets | Commits ------- da441ae Fixed minor typos.
This PR was merged into the 2.3 branch. Discussion ---------- [Reference] consistent & complete config examples | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Make configuration examples in the reference section consistent throughout the different configuration formats. Also fixing several syntax issues. This follow #4114 and #4129. Commits ------- 01dc25c [Reference] consistent & complete config examples
Fixes an issue (https://github.com/symfony/symfony-standard/issues/662) on symfony-standard.
Conflicts: cookbook/deployment/tools.rst
|
I think I bombed this PR. |
|
you can just push -f and save it, no need to open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue (https://github.com/symfony/symfony-standard/issues/662) on symfony-standard.