Skip to content

[RFR] Misc. minor fixes mostly related to formatting issues #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 7, 2014
Merged

[RFR] Misc. minor fixes mostly related to formatting issues #3899

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
79bf0a1
Misc. minor fixes mostly related to formatting issues
javiereguiluz Jun 2, 2014
00b3d26
Added the suggestions made by the great @WouterJ
javiereguiluz Jun 2, 2014
dee3180
Fixed the formating of one table (it now uses proper headers)
javiereguiluz Jun 2, 2014
0554cae
Fixed some minor formatting issues related to lists
javiereguiluz Jun 3, 2014
4641c66
Fixed the formatting of one table headers
javiereguiluz Jun 3, 2014
9a71577
Removed a tip inside a sidebar
javiereguiluz Jun 3, 2014
314c131
Fixed the indentation of one code block
javiereguiluz Jun 3, 2014
81fe666
Fixed more table headers formatting
javiereguiluz Jun 3, 2014
6625ff2
Fixed the indentation of a bulleted list
javiereguiluz Jun 3, 2014
2deb5d7
Added some links to API methods
javiereguiluz Jun 4, 2014
3b557a0
Fixed the formatting of several lists to avoid problems when
javiereguiluz Jun 4, 2014
e871a32
Fixed a very minor indentation issue
javiereguiluz Jun 4, 2014
b223417
Replaced a sidebar with a tip directive
javiereguiluz Jun 4, 2014
03b83ba
Splitted one tip directive into two smaller tips
javiereguiluz Jun 4, 2014
d38f00e
Fixed a minor indenttation issue
javiereguiluz Jun 4, 2014
2442839
Reverted the changes in the numbered lists
javiereguiluz Jun 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed a tip inside a sidebar 
Adding a tip inside a short sidebar isn't very normal. Moreover
it doesn't look right on the website.
  • Loading branch information
@javiereguiluz
javiereguiluz committed Jun 3, 2014
commit 9a715778c5aa4e68d2e093215eba6614216f5d63
10 changes: 3 additions & 7 deletions components/routing/hostname_pattern.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,9 @@ instance, if you want to match both ``m.example.com`` and
.. sidebar:: Using Service Parameters

You can also use service parameters if you do not want to hardcode the
hostname:

.. tip::

Make sure you also include a default option for the ``domain`` placeholder,
otherwise you need to include a domain value each time you generate
a URL using the route.
hostname. Make sure you also include a default option for the ``domain``
placeholder, otherwise you need to include a domain value each time you
generate a URL using the route.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tip has nothing to do with the sidebar. Let's readd the tip directive, but move it outside the sidebar.

Besides that, why is the example in the sidebar gone? In the current state, I would not say the content is a sidebar section, a tip directive would be better imo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced the whole sidebar by a tip. If this is not correct, please tell me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be 2 seperate tip directives, since they are about completely different things


.. configuration-block::

Expand Down