Skip to content

Update validation.rst. Remove the print_r statement to match the expected output. (so the __toString method is called) #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update validation.rst. Remove the print_r statement to match the expected output. (so the __toString method is called) #3229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/validation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ simple example from inside a controller::
$errors = $validator->validate($author);

if (count($errors) > 0) {
return new Response(print_r($errors, true));
return new Response($errors);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work. The Response constructor expects a string or an object castable to string. ConstraintViolationList is not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, sorry, actually it is. I never used the string casting on it though (and it is there only for debugging purpose anyway, so using print_r in the doc would at least make it clear it is not production-ready)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been tested by me and my workmate.

Using print_r returns a big output with a lot of noise. Nothing to do with
the expected results as describe in the doc.

When passing directly $errors, the output is exaclty the one described in
the doc. :)

Edit: Ok. Seen your second message :

I'm not against the usage of print_r, but in this case the description in
the doc should be accurate. Because it says the output should be
"Acme\BlogBundle\Author.name: This value should not be blank" but it's not
that at all. It's a big frightening bunch of data ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know you could do this either :), but makes sense! For clarification, I just split it into multiple lines and added a note at sha: 1a425cc. You don't get the nice-ness of relying on the automatic (string) casting in Response, but this is pretty much just for debugging/playing, so I think clarity is more important.

}

return new Response('The author is valid! Yes!');
Expand Down