Skip to content

Typos #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2013
Merged

Typos #3224

merged 1 commit into from
Dec 23, 2013

Conversation

petk
Copy link
Contributor

@petk petk commented Nov 24, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets n/a

@@ -284,4 +284,4 @@ Learn more from the Cookbook

* :doc:`/cookbook/bundles/extension`

.. _standards: http://symfony.com/PSR0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot It looks like the PSR0 link at symfony.com is now broken (you added it way back at sha: 019302f). We can change back, but I'm guessing you'd rather fix this :).

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason why symfony should have a PSR0 page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, turns out it was just redirecting to the PSR-0 standard: http://web.archive.org/web/20130814171407/http://symfony.com/PSR0

I don't see any reason to use it in our docs, instead of the official github link.

@petk
Copy link
Contributor Author

petk commented Nov 30, 2013

Since this PR is still alive and opened I've added some more fixes here. Regards.

@wouterj wouterj mentioned this pull request Dec 7, 2013
@wouterj
Copy link
Member

wouterj commented Dec 7, 2013

@peterkokot this now needs a rebase, and can you please change the PSR links to http://www.php-fig.org/psr/psr-0/ instead?

@petk
Copy link
Contributor Author

petk commented Dec 11, 2013

@wouterj: rebased and links to PSR updated. Regards.

weaverryan added a commit that referenced this pull request Dec 23, 2013
@weaverryan weaverryan merged commit 64d8026 into symfony:2.2 Dec 23, 2013
@weaverryan
Copy link
Member

Thanks Peter! I'm glad I left this open a bit longer so you could add more ;) - a lot of fixes!

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants