Skip to content

Fix technology, vendor and bundle names to their official notation #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 18, 2013
Merged

Fix technology, vendor and bundle names to their official notation #3186

merged 8 commits into from
Nov 18, 2013

Conversation

bicpi
Copy link
Contributor

@bicpi bicpi commented Nov 16, 2013

Q A
Doc fix? yes
New docs? -
Applies to 2.2+
Fixed tickets -

This PR renames all names of technologies, vendor software and bundles to their official names, following some official source, i.e. a homepage, GitHub, specification or Wikipedia:

  • YAML
  • Git
  • Symfony Standard Edition
  • XML
  • PHP
  • Twig
  • Symfony (except when it refers to version 1)
  • Subversion / SVN
  • UglifyJS
  • UglifyCSS
  • Apache
  • JavaScript
  • Java
  • Composer
  • CSS
  • Node.js
  • Xdebug
  • HTTP
  • HTTPS
  • Ajax
  • IP
  • ACL
  • FOSUserBundle
  • WSSE

It also removes literal formatting from some of them.

In addition, it removes the literal formatting from the official bundle names as this seems to be the more used standard throughout the docs and as a bundle name does not reference a piece of code or a file name etc.:

  • FrameworkBundle
  • FOSUserBundle
  • AcmeDemoBundle
  • DoctrineBundle
  • DoctrineFixturesBundle
  • SwiftmailerBundle
  • TwigBundle
  • JMSSecurityExtraBundle

Bundle names used in code samples are not affected, e.g.: AcmeUserBundle, AcmeBlogBundle, AcmeNewBundle, AcmeStoreBundle etc.

Along the way, this PR fixes some formatting issues and typos.

@weaverryan weaverryan merged commit 2834fd2 into symfony:2.2 Nov 18, 2013
@wouterj
Copy link
Member

wouterj commented Nov 18, 2013

wow... Now I need a lot more things to look out for when reviewing PRs.... ;-)

@xabbuh
Copy link
Member

xabbuh commented Nov 18, 2013

Much more chances for you to find mistakes. :D

@weaverryan
Copy link
Member

@wouterj I know, right? :) Thanks @bicpi for this HUGE PR and all the consistency changes you've been making lately. An incredible amount of work!

Cheers!

@wouterj
Copy link
Member

wouterj commented Nov 18, 2013

@xabbuh yeah, I like decorating a PR :)

But indeed, @bicpi, you are doing an incredible job on consistency in the docs. I love that! It reminds me of my first PRs... ;-) #1531 #1597 #1798

@bicpi
Copy link
Contributor Author

bicpi commented Nov 19, 2013

Thank you and actually, it's quite fun to work on it. As I read the docs anyway every day, I thought why not fix it along the way. @wouterj Hope you don't mind arsing sentimental feelings with all those PRs ;-)

@bicpi bicpi deleted the fix_proper_nouns_and_some_formatting branch January 5, 2014 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants