Repository navigation
[Security] Fix lowest argon time_cost in PHP config example - #23106
Merged
Merged
Conversation
Member
|
Good catch, thanks @tahakotil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The YAML example in this section says
time_cost: 3 # Lowest possible value for argon, but the equivalent PHP config example used->timeCost(2).time_costmaps toopsLimit, andSodiumPasswordHasherrejects any value below 3 ('$opsLimit must be 3 or greater.', seeSodiumPasswordHasher::__construct). The auto hasher resolves to sodium when libsodium is available, so the PHP example would fail with the stated "lowest possible" value. Fixed the 8.1/8.2 branches already use 3 in both blocks; 6.4 and 7.4 were inconsistent.