[RateLimiter] Use the standard "Retry-After" header in the rate limiter example#22370
Merged
Merged
Conversation
carsonbot
changed the title
MrYamous
reviewed
Jun 3, 2026
The example exposed a non-standard "X-RateLimit-Retry-After" header. The standard HTTP header for 429 responses is "Retry-After", which is also set automatically by TooManyRequestsHttpException, so the example now throws that exception instead of building the header by hand. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/429
bendavies
force-pushed
the
fix-retry-after-header
branch
from
a93401d to
4722730
Compare
javiereguiluz
added
Status: Reviewed
RateLimiter
and removed
Status: Needs Review
labels
carsonbot
changed the title
Member
|
This is a solid improvement! Thanks a lot Ben. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Exposing the Rate Limiter Status" example exposed a non-standard
X-RateLimit-Retry-Afterheader. The standard HTTP header for429 Too Many Requestsresponses isRetry-After:https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status/429
Since
TooManyRequestsHttpExceptionalready sets theRetry-Afterheaderfrom its first constructor argument, the example now throws that exception
instead of building the header by hand. This also matches the earlier
"Using the Rate Limiter Service" example, which throws the same exception.