Skip to content

[Mailer] [Smtp] Add source_ip option #20581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

quilius
Copy link
Contributor

@quilius quilius commented Jan 17, 2025

This PR documents the source_ip feature in this PR: https://github.com/symfony/symfony/pull/59482/files

@carsonbot carsonbot added this to the 7.3 milestone Jan 17, 2025
@quilius quilius force-pushed the bind_to_ipv4_or_ipv6 branch 2 times, most recently from 935a3c4 to 64841c2 Compare January 17, 2025 14:41
@quilius quilius requested a review from xabbuh as a code owner January 17, 2025 14:46
@quilius
Copy link
Contributor Author

quilius commented Jan 17, 2025

I've replaced all occurrences of .. versionadded:: 7.3 with .. deprecated:: 7.3 because DOCtor-RST was failing.

@xabbuh xabbuh added the Waiting Code Merge Docs for features pending to be merged label Jan 18, 2025
@carsonbot carsonbot modified the milestones: 7.3, next Jan 18, 2025
@xabbuh xabbuh removed the Waiting Code Merge Docs for features pending to be merged label Jan 18, 2025
@xabbuh xabbuh modified the milestones: next, 7.3 Jan 18, 2025
@xabbuh
Copy link
Member

xabbuh commented Jan 18, 2025

@quilius please revert the versionadded to deprecated changes, we have fixed the build in #20584

@quilius quilius force-pushed the bind_to_ipv4_or_ipv6 branch from 80910ef to 0cda667 Compare January 18, 2025 10:00
@javiereguiluz javiereguiluz merged commit 799b63b into symfony:7.3 Jan 20, 2025
3 checks passed
@javiereguiluz
Copy link
Member

@quilius thanks for updating the docs about this new feature ... and congrats on your first Symfony Docs contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants