Skip to content

[Console] Document FinishedIndicator for Progress indicator #20300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Oct 6, 2024

Hello 👋

I give a try to fix #20296

@carsonbot carsonbot added this to the 7.2 milestone Oct 6, 2024
@Jibbarth Jibbarth force-pushed the patch-3 branch 2 times, most recently from e4d5028 to ae59ff4 Compare October 6, 2024 20:48
@javiereguiluz javiereguiluz merged commit 8fd7a08 into symfony:7.2 Oct 7, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Jibé!

While merging I removed the heading Custom Finished Indicator and merged this new section into the existing Custom Indicator Values section because I think the reading flow is better that way. Thanks!

@LauLaman
Copy link
Contributor

@Jibbarth Thank you!

javiereguiluz added a commit that referenced this pull request Oct 16, 2024
…gress indicator (LauLaman)

This PR was merged into the 7.2 branch.

Discussion
----------

[Console] Update FinishedIndicator documentation for Progress indicator

Hi!

This is a correction to PR #20300 Which makes a wrong statement about the finished indicator.

This MR seeks to resolve this and make the documentation more clear

closes #20296

Commits
-------

93ca378 Update progressindicator.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants